News for hackers. Stuff that matters.
Re:Code review review is the manager’s job by zdragnar on Wednesday August 15, 2018 @01:09PM (#17767734)
Of the companies I've worked at, my favorite setup was:

* people manager dealt with people issues

* technical reviews performed by senior technical people (under the same people manager, or cross teams if noone else is at the same / higher level)

* technical review is a part of the people manager's management responsibility: is it done on time, is the reviewee satisfied with the content and criticism of the review, etc.

This prevented a lot of personal opinion blight from influencing technical reviews- aka avoided subjective criticism from being part of the review score, focused instead on more objective metrics.

The time and place for subjective criticism and discussion is in planning and in-situ reviews (aka pull / merge requests), not formal reviews.

That's my experience at least; the particular managers I had at that company (3 over 7 years) also happened to be excellent people on the whole. A bad people manager is, of course, just as bad as a bad technical manager.

There are no comments on this comment yet.