Re:Code review review is the manager’s job
by FlipperBucket on Wednesday August 15, 2018 @12:14PM
(#17767181)
> Code Review should be about catching mistakes.
Overly-complicated code is a mistake. Maintainability matters almost as much as a passing unit test. You want your code reviews to catch meaningful things, but they often end up being about things like this (fixing inefficient small bits of code).
Overly-complicated code is a mistake. Maintainability matters almost as much as a passing unit test. You want your code reviews to catch meaningful things, but they often end up being about things like this (fixing inefficient small bits of code).
e.g.
vs vs