Re:Code review review is the manager’s job
by maxxxxx on Wednesday August 15, 2018 @09:27AM
(#17765837)
How much time do you take for a code review? If I did a full review that really tries to understand the code it would take me close to the time it took to write the code. But I don't get that time. So I pretty much nitpick on some style issues but rarely find any real problems.
[ Parent
| on HN ]
Re:Code review review is the manager’s job
by bluesnowmonkey on Wednesday August 15, 2018 @11:23AM
(#17766729)
That's just it, code review done right takes time. If the author spent four hours on a change, I might spend an hour just reviewing it. You have to understand the problem and the solution just as well as the author.