> It feels counter-intuitive to find cynicism positively correlated with prosocial behaviour (which the article defines as donating to and/or joining a charity.)

Does it? I would expect both to follow from, for want of a better term, "caring more": you would expect someone who is more sensitive to bad things to be both cynical and prosocial than someone who noticed bad things less.