News for hackers. Stuff that matters.
Re:Code review review is the manager’s job by sgt101 on Wednesday August 15, 2018 @05:04AM (#17764621)
Are there any field studies that demonstrate the impact and efficiency of these practices? Is there a body of evidence to support the assertions that are made in this post?
Re:Code review review is the manager’s job by johnb on Wednesday August 15, 2018 @05:27AM (#17764717)
Hi - author here.

The quality assertions are the most defensible empirically. I wrote the post at the office away from my bookshelf which was the main thing keeping me from including them up front (flicking through my old copy of code complete now). Capers Jones' "Software Defect-Removal Efficiency" (https://ieeexplore.ieee.org/document/488361/) would be the main one on the effectiveness rate of code inspections. I've collected a few other relevant papers over at https://github.com/joho/awesome-code-review

The second two themes around education and culture come more from my personal perspective and experience - largely from running the engineering teams at Envato and 99designs respectively. My feeling is the educational and safety elements of code review have come up online a lot more over the past couple of years - but that's just my anecdotal view.

Re:Code review review is the manager’s job by sgt101 on Wednesday August 15, 2018 @07:05AM (#17765142)
Some good points - many thanks.

I think that there is a market failure / exec education issue around these point though. The impact of the improvements measured/evidenced is in the maintenance cost of the delivered artefact and the improvement of the process for future delivery. These are "over the fence" issues for the owners of the delivery shop. We need to get it into the bosses minds that they are paying for things that will be either good in the long term or expensive in the long term - I think that there is a lot of hiding and hedging and shifting of burden (to users) that goes on around that.

Re:Code review review is the manager’s job by johnb on Wednesday August 15, 2018 @07:39AM (#17765268)
I agree and trying to cover that education gap is what I'm trying to achieve with the post (and the product behind it)
Re:Code review review is the manager’s job by blazespin on Wednesday August 15, 2018 @06:08AM (#17764856)
Unfortunately, productivity is always context dependent.
Re:Code review review is the manager’s job by JackMorgan on Wednesday August 15, 2018 @05:46AM (#17764781)
Here's the thing, there's no way to measure programming productivity at all, so, no, there's no valid studies about anything ever. The studies that try always suffer from this inherent flaw. They count bugs, lines of code, function points, all metrics that aren't actual business value.

Pair programming vs code review, Nodejs vs Ruby, React vs Vue, Vim vs Atom, etc etc etc are all 100% emotional and subjective decisions. Therefore they are subject to fashion, being cool, and herd mentality.

Accepting this is an essential step on the path to become a well-rounded engineer.

Re:Code review review is the manager’s job by johnb on Wednesday August 15, 2018 @05:49AM (#17764799)
That's not really true. A better formulation is that there's no way to manage programming productivity cheaply and/or non-intrusively.

I agree that the bulk of X vs Y comparisons are emotive and subject to what Alan Kay calls the "pop culture" but that in no way demonstrates that measurement is out of reach. It's just in most contexts we don't care to do the work to measure it out of personal preference or economic reality.

Re:Code review review is the manager’s job by JackMorgan on Wednesday August 15, 2018 @06:06AM (#17764850)
Good point, productivity measurement is probably possible, but so vastly expensive enough that it's not happened yet.

I really like this post and the one about managers programming btw. Your common sense explanation to why most new managers end up coming back and reporting that they shouldn't code is exactly what I've seen as well.

Re:Code review review is the manager’s job by johnb on Wednesday August 15, 2018 @06:13AM (#17764873)
There was an old Tom DeMarco article I'm a fan of: http://www.systemsguild.com/pdfs/DeMarcoNov2011.pdf

In it he has a pretty interesting insight about late projects. "If a project offered a value of 10 times its estimated cost, no one would care if the actual cost to get it done were double the estimate. On the other hand, if expected value were only 10 percent greater than expected cost, lateness would be a disaster."

I imagine as our field matures measuring productivity and hitting estimates will get more important once software has finished eating the world. The unlimited (or close to) upside dev projects will be largely behind us and we'll need to hit tighter economic targets. I'm just glad I'm working in the era where I don't need to measure it :D

Glad you like the posts. Thank you!

Re:Code review review is the manager’s job by JackMorgan on Wednesday August 15, 2018 @07:26AM (#17765222)
You are the first person I've talked to who also thinks the "eating the world" will come to a natural end! I think the natural conclusion is that in X years there will be only a fraction of the number of working programmers as today. The margins will get tighter, and the gains smaller.

It is sad in a way, but also exciting as you say to be in the golden age.

Re:Code review review is the manager’s job by sgt101 on Wednesday August 15, 2018 @11:08AM (#17766585)
Mind you, the maintenance burden and the dependency of the users on the legacy will be ever larger. Also - as things are digitized the opportunity for more and more digitization grows.
Re:Code review review is the manager’s job by sgt101 on Wednesday August 15, 2018 @07:01AM (#17765128)
I think that DeMarco is wrong about that already in the corporate world. The budgets and schedules that I work with are organised around knowing what is going to arrive when, crudely 10x -> 5x means that 5x is not available for the next round of projects, which means that 5 projects get canned. Any project running 2x will result in a big change of "staff responsibility" basically because no one trusts anyone involved any more.