Removing jQuery from GitHub.com frontend

Re:Removing jQuery from GitHub.com frontend by Sephr on Wednesday July 25, 2018 @05:36PM (#17613100)

element.replaceWith(replacement) is just an alias for element.parentNode.replaceChild(element, replacement) with some bonus functionality to convert strings to DOM text nodes. parentNode.replaceChild is not exactly a 'hacky' alternative.

Here it is in the form of a basic polyfill that only supports Elements:

    Element.prototype.replaceWith = function(replacement) {
        if (typeof replacement === "string") {
            replacement = this.ownerDocument.createTextNode(replacement);
        }
        this.parentNode.replaceChild(this, replacement);
    }

[ Parent | on HN ]

Re:Removing jQuery from GitHub.com frontend by interlocutor on Wednesday July 25, 2018 @05:40PM (#17613142)

Is that just as readable? Is the intent just as clear? Is the improved readability of the jQuery version worth the extra 80kb download to you?

EDIT: Regarding the polyfill, now you are beginning to write your own little jQuery clone.

[ Parent | on HN ]

Re:Removing jQuery from GitHub.com frontend by Sephr on Wednesday July 25, 2018 @05:44PM (#17613176)

GitHub says they are using polyfills instead of jQuery as well. The point is to not have to rely on external frameworks.

[ Parent | on HN ]

Re:Removing jQuery from GitHub.com frontend by balfirevic on Wednesday July 25, 2018 @06:16PM (#17613419)

> The point is to not have to rely on external frameworks.

Why is that a worthwhile goal?

[ Parent | on HN ]

Re:Removing jQuery from GitHub.com frontend by mschuster91 on Wednesday July 25, 2018 @06:23PM (#17613470)

To reduce attack surface as well as maintenance burden for compatibility whenever something breaks during an upgrade.

A polyfill is something that's not needed at all in modern browsers and thus can be considered pretty much final. jQuery is actually surprisingly stable compared to Angular/React/npm/rest-of-the-hipster-crap, but it has had its fair share of incompatibilities too.

[ Parent | on HN ]

Re:Removing jQuery from GitHub.com frontend by Spivak on Thursday July 26, 2018 @09:38PM (#17622832)

Is a set of polyfills philosophically different than a framework?

[ Parent | on HN ]