GitHub mirror compromise incident report

Re:GitHub mirror compromise incident report by kace91 on Wednesday July 04, 2018 @07:50PM (#17460040)

For mine every feat/fix/refactor is a new branch which then requires 2 approvals to get merged, among other things (style guide enforced as linting, minimum test coverage threshold, etc ).

Tbh it's cool, coming from a previous job at a startup where version control meant just zipping the project from time to time.

[ Parent | on HN ]

Re:GitHub mirror compromise incident report by ff_ on Thursday July 05, 2018 @01:07AM (#17460993)

Same here. All code goes in a Pull Request, and requires at least 1 approval.

Since Pull Request review is a high priority activity there's no "bottleneck", and you double the bus factor for free + prevent bad things from happening.

[ Parent | on HN ]

Re:GitHub mirror compromise incident report by rich-w-big-ego on Thursday July 05, 2018 @01:45AM (#17461103)

Yeah but you can still push commits to a PR that has received approval, and the approval is not revoked.

[ Parent | on HN ]

Re:GitHub mirror compromise incident report by jimwalsh on Wednesday July 04, 2018 @11:20PM (#17460657)

This is what happens where I work as well.

[ Parent | on HN ]