Re:Ask HN: What is the first thing you implement at a new co...
by dasil003 on Wednesday June 20, 2018 @10:28AM
(#17355707)
Even bad developers have reasons, you may not be able to divine those reasons but they may be legitimate. The would-be refactorer would do well to consider carefully what the reason might have been, even if a git-blame reveals a less-than-excellent contributor.
As an programmer I always try to capture these reasons in my commit messages, after a decade of doing this I’ve gotten a lot of thank you notes years after leaving a project, and I’ve even reminded myself details about my own thought process that I had otherwise would have long forgotten.
One thing I’ve learned by having long tenures is that context change over years is much more likely the reason for nonsensical code than developer stupidity.
Re:Ask HN: What is the first thing you implement at a new co...
by SketchySeaBeast on Wednesday June 20, 2018 @10:20AM
(#17355610)
> some testcases of required behavior, and then refactor only code that is supported by tests
The difficulty is making sure that you have all the requirements and aren't missing any, and once a system gets big enough, that gets really difficult.
That's why it's important to start with some testcases of required behavior, and then refactor only code that is supported by tests. Because sometimes the fence is there for a reason, but often it's not.