Re:Python idiom for taking the single item from a list
by jemfinch on Monday September 27, 2010 @05:26PM
(#1733507)
Yes, you should definitely should be more explicit if that's what you intend to check: PEP8 makes that explicit.
I'm not sure why you'd defend against None anyway. Why defend against None, but not against 3.1459 or 4j or ''?
Re:Python idiom for taking the single item from a list
by statictype on Monday September 27, 2010 @08:57PM
(#1734182)
There's nothing wrong with `is l`. Sounds like you're just splitting hairs.
He's defending against None because calling __len__ on None results in an exception.
3.14159 also results in an exception but it's far more likely that the object passed was None than that it was a completely different type than the one expected.
Re:Python idiom for taking the single item from a list
by jemfinch on Tuesday September 28, 2010 @04:24PM
(#1737146)
> it's far more likely that the object passed was None than that it was a completely different type than the one expected.
FYI, None is a completely different type than the one expected.
And as was mentioned the "assert l" part is defending against l being None. I suppose I could be more explicit by saying "assert l is not None and len(l) == 1".