Re:Another flaw in Signal desktop app leaks chats in plaintext
by archgoon on Thursday May 17, 2018 @11:21PM
(#17098432)
This doesn't seem to be true, here's the v1.10.0 code:
https://github.com/signalapp/Signal-Desktop/blob/f6eb745632c...
They do seem to be using react, and using dangerouslySetInnerHTML. Now that said, I haven't confirmed that this is the code that caused the issue, but it is in the Quotes component, which is referenced in the article.
They seem to have fixed this specific issue a few days ago (v.11.0):
https://github.com/signalapp/Signal-Desktop/blob/0d00fbfb7a2...
They do seem to be using jQuery elsewhere in the code base, but I'm not familiar enough to determine how it all fits together.
Re:Another flaw in Signal desktop app leaks chats in plaintext
by vjeux on Friday May 18, 2018 @12:43AM
(#17098761)
Oh sorry you are right! I was reading the comment ( https://news.ycombinator.com/item?id=17097501 ) which said that the issue was caused with $.html
The app isn't using React but jQuery, which doesn't have those protections.