VS Code is great but will never replace Visual Studio. They are different beasts. I could see the two gravitating towards each other but I never see the one winning outright. There are a vast spectrum of developers out and its okay that there is no single IDE that fits everyone perfectly.