Unlearning toxic behaviors in a code review culture

Re:Unlearning toxic behaviors in a code review culture by yxhuvud on Saturday April 28, 2018 @03:10PM (#16949024)

I'd create an initial separate commit with only style changes and then have my new or changed code follow the code standard. The code converges very fast if everyone does that.

[ Parent | on HN ]

Re:Unlearning toxic behaviors in a code review culture by Izkata on Saturday April 28, 2018 @08:08PM (#16950091)

Caveat: Try to time it carefully if the code is being actively developed, to reduce risk of merge conflicts and annoyances to the rest of the team. It just leads to a lot of "stop doing that!" and further resistance to that kind of refactoring.

[ Parent | on HN ]

Re:Unlearning toxic behaviors in a code review culture by kronin on Saturday April 28, 2018 @03:55PM (#16949170)

1,000x this. A simple refactor commit, with a comment stating "reformat to match current coding standards. No functional changes".

[ Parent | on HN ]