Unlearning toxic behaviors in a code review culture

Re:Unlearning toxic behaviors in a code review culture by inertiatic on Saturday April 28, 2018 @01:55PM (#16948762)

Well, this makes sense somewhat. Files will be edited incrementally to the point that nothing remains from the original. If you follow your strategy, the original style remains there until a large rewrite. If you make a point to always follow the official style, then at some point you'll automagically have a consistent codebase.

[ Parent | on HN ]

Re:Unlearning toxic behaviors in a code review culture by loeg on Saturday April 28, 2018 @03:01PM (#16948987)

I disagree that incrementally converting style is helpful. It's best to be consistent in a given file or module. Convert wholesale if so desired.

[ Parent | on HN ]

Re:Unlearning toxic behaviors in a code review culture by mhotchen on Saturday April 28, 2018 @02:31PM (#16948894)

I think it depends on your environment. I've been in situations where code styles have progressed and changed over the years, faster than the file does, so you end up with a hodgepodge of different styles.

[ Parent | on HN ]