News for hackers. Stuff that matters.
Re:Be likeable or get fired by eloff on Friday April 20, 2018 @09:58AM (#16884792)
What a toxic environment, it sounds like you did that developer a favor in the long run by saving him from having to work with you.

A developer took the time to review the existing code, and point out things that could be improved upon. That's part of our job. Even if you don't want to make any changes, or he's wrong about some of the feedback, you should be grateful to him/her.

How much revenue your code is earning says nothing about the quality of the code. That you feel the need to mention it says something about your ego.

Re:Be likeable or get fired by balfirevic on Friday April 20, 2018 @11:52AM (#16885803)
> How much revenue your code is earning says nothing about the quality of the code.

It does say something. In this case, it might be saying that, for this particular application, the quality of code is simply not that important.

Re:Be likeable or get fired by alex_hitchins on Friday April 20, 2018 @12:07PM (#16885940)
Or perhaps that figure could be doubled with leaner code that's quicker to work with and understand.
Re:Be likeable or get fired by cocoablazing on Friday April 20, 2018 @12:49PM (#16886392)
It’s possible that this code has bugs that have yet to be detected. It’s a fact that quality is important if it can generate losses. Style may not be particularly important, but reliability is.
Re:Be likeable or get fired by eloff on Friday April 20, 2018 @12:22PM (#16886085)
No it doesn't. It's a variable that doesn't enter the equation at all.

Maybe the technical debt should be reduced, saving the company money down the road by reduced maintenance costs and reduced issues as development continues.

Maybe the code is feature complete and there's no reason to change what works. It has technical debt, but perhaps the business calculation is that there's not enough benefit to cleaning it up (and in fact messing with working code may introduce issues.)

Either way you look at it, how much revenue it produces doesn't enter into the calculation.

Now you might say the revenue is so low that the code brings little value to the company and so the technical debt doesn't matter. But again that's looking at the wrong thing. Even if it brings in zero revenue, as long as development is ongoing because it brings some other form of value to the company, then the technical debt matters. The right things to look at are the costs involved in cleaning up the technical debt, vs the costs of continuing on while ignoring it. It's all about weighing costs and not about revenue.

Re:Be likeable or get fired by adamsea on Friday April 20, 2018 @12:30PM (#16886181)
Revenue is actually the only calculation - it is a business.
Re:Be likeable or get fired by eloff on Friday April 20, 2018 @01:07PM (#16886542)
No, it's profit = revenue - costs.

But it doesn't matter to this particular decision which is weighing one cost (technical debt) against another cost (fixing said debt.) There is no revenue in the calculation at all to consider, just costs.

Re:Be likeable or get fired by cocoablazing on Friday April 20, 2018 @12:51PM (#16886405)
So they need profit, which is negatively impacted by costs.
Re:Be likeable or get fired by notyourday on Saturday April 21, 2018 @11:20AM (#16891727)
> How much revenue your code is earning says nothing about the quality of the code.

It says everything it needs to say. Revenue pays developer salaries.