News for hackers. Stuff that matters.
Re:Ask HN: Do you do code review? by bostik on Sunday April 15, 2018 @05:00PM (#16844945)
We have mandatory code reviews for everything, which encourages small, bite-size commits and frequent merges. Majority of the changes goes through with just one other person taking a look.

But we also specify (and highly encourage) that anyone trying to land a more invasive or complex change should require multiple review approvals. The most demanding "please pile on, we want eyes on this" request I remember was set to require 4 separate approvals.

Re:Ask HN: Do you do code review? by throwaway84742 on Monday April 16, 2018 @02:06AM (#16846968)
TBH I favor atomicity over small size. So we get a few gnarly PRs a week. That’s also why we use Reviewable instead of GitHub reviews