News for hackers. Stuff that matters.

A comment on React v16.3.0: New lifecycles and context API. Parent comment

Re:React v16.3.0: New lifecycles and context API by djhartman on Friday March 30, 2018 @01:03PM (#16717812)
In your experience, what are the kind of things that people do in `componentWillMount` that they shouldn't be doing? Is it correct to say that `getSnapshotBeforeUpdate` is named to indicate what you were supposed to use `componentWillMount` for?

Thanks to you and brianvaughn for answering so many questions.

[ Parent | on HN ]
Re:React v16.3.0: New lifecycles and context API by brianvaughn on Friday March 30, 2018 @01:35PM (#16718102)
> In your experience, what are the kind of things that people do in `componentWillMount` that they shouldn't be doing?

The biggest one is probably adding event listeners or setting up subscriptions (which can cause memory leaks).

Here are some others: https://github.com/reactjs/rfcs/blob/master/text/0006-static...

> Is it correct to say that `getSnapshotBeforeUpdate` is named to indicate what you were supposed to use `componentWillMount` for?

No. `getSnapshotBeforeUpdate` is not really related to `componentWillMount`. It relates more to what people were using `componentWillUpdate` for.

[ Parent | on HN ]