Re:Require multiple reviewers for pull requests
by viraptor on Saturday March 24, 2018 @02:20AM
(#16665165)
There are also 2 cases of tunnel vision that I started noticing in reviews.
1. You've been working on some non-trivial change for long enough that you find some element of it trivial and not worth documenting, but others have no idea why it's there.
2. You've been looking at something so long that a "temporary code, I'll fix it later" starts looking natural and it takes someone else to call it out.
I don't want to enter the people vs. systems debate but certainly a good system can help.