How I built a fast JavaScript framework

Re:How I built a fast JavaScript framework by pygy_ on Wednesday March 07, 2018 @01:42PM (#16538677)

https://github.com/radi-js/radi/blob/eace84e9b74c944b233f631...

It parses the source code of the view function at run time, matching parentheses, but ignoring whether those are present in strings or regexes. Likewise, the comment stripper will turn

    "/*whoops*/"

into the empty string...

In other words, the parser is buggy :-/

[ Parent | on HN ]

Re:How I built a fast JavaScript framework by lhorie on Thursday March 08, 2018 @12:06PM (#16545735)

Having taken a closer look, it looks like the problems go even deeper than that: it rewrites `l()` calls in functions through a regex/replace on `fn.toString()`. This is similar to the mechanism that broke shorthand Angular.js DI in production. So code can break if it goes through some bundler than renames the `l` variable, or if a minifier does it, etc.

I'd imagine closures also break.

[ Parent | on HN ]

Re:How I built a fast JavaScript framework by pygy_ on Thursday March 08, 2018 @12:20PM (#16545877)

Closures will break, yes. It looks like it is intended to react to mutations to the properties of `this`...

I hadn't thought of minification, yes it pretty bad :-/...

It looks like the author is smart but has little JS experience (`var last = temp.splice(-1)[0]` where `temp.pop()` would do tells me that it may be one of his first JS project).

[ Parent | on HN ]