It is true that the statistics show that those who are born with the right traits to succeed in life are more likely to do well in school and in the workplace, which is unsurprising. Life is a gradient, but when we take it to the logical extreme, it becomes quite apparent that someone with a crippling mental disability is not going to be able to go far in school, nor are they going to be a top choice to do business with. But that does not mean that there are not cases where people who are born with the right traits slip through the system. The education system is big and complex and sometimes fails. Someone with successful traits does not lose their successful traits from that experience.
That said, I agree that there is more to life than career success. The enrichment that school could have provided him may have made his life better in other ways.
I feel like the raw statistics are a bit misleading here, because yes, on average, formal education improves outcomes. And I think most of us here are hardcore outliers, and have a passion for learning and self-development outside of a formal education context.
A passion for learning only helps if you learn useful things, and a child with ADHD will focus on what they find interesting. And I don't see how improving your ability to focus on uninteresting things would have held you back.
I've found the most magic in finding the intersection of useful and interesting, and suspect that this has led me to more satisfaction than someone who has found something only useful and used their willpower to focus on it.
Second,those aren't the two options. You're gaining the ability to focus on uninteresting things, something people without ADHD have and don't use constantly. All the traits mentioned in your last post don't disappear when you add the ability to focus.
How likely is it the failing in school helps you? Not very.
Given that you have succeeded because of failing in school, what was the probability that failing in school helped you? There's no such thing as that probability because there's no such thing as how likely it is that your actual outcome came about. There's no such thing as what fraction of possible life-outcomes are similar to your actual outcome. At least you can't possibly know these things.