Re:GitHub: Commit together with co-authors
by jwilk on Tuesday January 30, 2018 @07:23AM
(#16264689)
It's not clear to me what the semantics of Signed-off-by is supposed to be, but at least for some projects (e.g. the Linux kernel), it doesn't imply that you are a co-author.
Re:GitHub: Commit together with co-authors
by WorldMaker on Tuesday January 30, 2018 @11:31AM
(#16266584)
That's what I've seen. Some projects, including the Linux kernel, use Signed-off-by for Developer Certificate of Origin legal processes.
https://elinux.org/Developer_Certificate_Of_Origin
It makes sense that GitHub would use something new to avoid stepping on toes, and GitHub's mirrors Signed-off-by in implementation as a git commit message trailer.
Re:GitHub: Commit together with co-authors
by brianmario on Tuesday January 30, 2018 @12:04PM
(#16266893)
The Co-authored-by trailer isn't actually new. In fact it was already being used by over ~1M commits on GitHub before we launched the feature! :)
The git-core commit message conventions docs mention it (https://git.wiki.kernel.org/index.php/CommitMessageConventio...) as do the OpenStack commit message convention docs (https://wiki.openstack.org/wiki/GitCommitMessages#Including_...).
Re:GitHub: Commit together with co-authors
by brianmario on Tuesday January 30, 2018 @10:41AM
(#16266136)
Using the Co-authored-by trailer is also really useful when pairing, where there is actually more than one author for the content.
This is especially useful when using https://teletype.atom.io :)
Edit: Now that I think about it, can see why. I have seen merges where is was good enough to merge, but needed som slight adjustments. Rebase/merge with minor changes would be a good use for this, and would allow for better crediting of both authors.