News for hackers. Stuff that matters.
Re:Facebook iPhone app takes OSS code without attribution by Mathnerd314 on Thursday August 19, 2010 @10:20PM (#1619303)
The files do essentially the same thing. So consider: is it possible that two development teams, implementing the same feature, will use the same style of implementation?

The code diff he presents seems to be UI code. How many ways are there to set a label's font? (though having the same exact pixel values is perhaps a bit odd)

The code is structured differently, named differently, and (to my untrained eyes) even appears to differ in some implementation details (such as setUpdateDate, which uses NSDateFormatterShortStyle, versus setCurrentDate, which uses its own custom format). Perhaps the author is simply feinting at shadows.

Re:Facebook iPhone app takes OSS code without attribution by mtigas on Thursday August 19, 2010 @10:36PM (#1619342)
I agree that implementation-wise, there are probably only so many ways to do this.

While the overall algorithm is basically the same (see http://github.com/facebook/three20/commit/0edd0ca58bf3b352e7... versus http://github.com/enormego/EGOTableViewPullRefresh/blob/mast... ), I'll give the Three20 folks credit for cleaning their implementation up into a view+delegate system.

It's a bold claim to say that your particular implementation has been "taken" when this sort of open idea and algorithm reuse happens all the time. In this situation, I'm sure once the dust clears credit will be given where it's due.

Tangent: Who wants to guess that some of the HN commenters up-in-arms about this are some of the folks who are cry foul about software patents?

Re:Facebook iPhone app takes OSS code without attribution by flyosity on Thursday August 19, 2010 @10:33PM (#1619335)
It's not about setting the label's properties in the exact same way & order (okay, that's also fishy), it's that they named all their UI elements the exact same names: _lastUpdatedLabel, _statusLabel, _arrowImage and _activityView.

I'm not sure why you said it's named differently, all the UI elements are named the same according to the screenshot they posted.

Re:Facebook iPhone app takes OSS code without attribution by Mathnerd314 on Saturday August 21, 2010 @11:05PM (#1624133)
He states that the code in the screenshot is "normalized" for a better diff. I believe this involved adding underscores to all of the variable names.
Re:Facebook iPhone app takes OSS code without attribution by jfager on Thursday August 19, 2010 @10:35PM (#1619341)
I wondered that, too, but if you go in and look at the projects, the pedigree is clear. Even if you're going to use a similar implementation style, the likelihood that you independently come up with the exact same instance variable names and initialize them in the exact same order is pretty small.

That said, this really seems like an out-of-proportion response to me. As much as I dislike FB, they're pretty decent OSS citizens. I think you have to give them a chance to make it right before throwing up a blog post.