Re:More Gotchas of Defer in Go, Part II
by Groxx on Thursday December 21, 2017 @05:09PM
(#15983301)
I have a comment at a higher level with a broader example, but for Go at least this is somewhat common:
There aren't many nice options for "if I can call X, defer a call to X" aside from shoving it into an `if`, where it'd be captured by that scope. I mean, you could do something like
but imagine doing that every time. It'd work, sure, but it'd also be more annoying.
[ Parent
| on HN ]
Re:More Gotchas of Defer in Go, Part II
by pcwalton on Thursday December 21, 2017 @08:03PM
(#15984439)
Couldn't you do:
func closeIfNecessary(object interface{}) {
closable, needsClosing := object.(closable)
if needsClosing {
closable.close()
}
}
And then just do: func f(i interface{}) {
defer closeIfNecessary(i)
...
}
Doing it this way also saves you boilerplate by factoring the downcast out into a separate function.As long as you can always call .close() regardless of the code below, yep - that'd work, and is definitely more readable.
If you can't call it unless [some other conditions], it goes back to the same kind of problem though. "closable" may not be a good choice on my part, as they're often called unconditionally.