News for hackers. Stuff that matters.

A comment on Oh shit, git: Getting myself out of bad situations. Parent comment

Re:Oh shit, git: Getting myself out of bad situations by falcolas on Monday December 18, 2017 @07:04PM (#15956658)
Personal opinion - re-reviewing a pull request when someone has erased all context from your last review of that PR via a rebase and force push is a royal PITA. Especially for changes that span more than a few files. Did they address your concerns? The only way to know is to go back through all of the changes on that feature branch, and hope you don't miss anything.

This, in contrast with just reviewing the latest commit, potentially going back to the rest of the changes with an eye towards the latest commit.

It frankly bugs the piss out of me when people rebase and ask me to review their latest changes - it feels disrespectful of my time.

[ Parent | on HN ]
Re:Oh shit, git: Getting myself out of bad situations by gwright on Monday December 18, 2017 @09:09PM (#15957213)
I've taken to making the change as a fixup commit and leaving it in the PR for code review. Then when the changes are approved a quick `git rebase -i --auto-squash` cleans everything up before merging the branch back into `develop`.
[ Parent | on HN ]