Re:The way Microsoft patched a recent bug raised some eyebrows
by b0rsuk on Tuesday November 21, 2017 @05:52AM
(#15747064)
While we're talking games, kyrub has made a splendid patch called "insecticide" for Master of Magic. The game famous for its vision, imagination and creativity but notorious for piles of bugs. The first few patches had several pages of bugfixes. Insecticide added many more pages, GUI improvements and AI tweaks.
Some bugs went unnoticed until very recently. For example I was one of playtesters of this patch, and I reported that Invulnerability spell appears impossible to dispel. Kyrub checked it out, and... would you believe ? There was an off-by-one error, Invulnerability was the last on the list. It was literally impossible to dispel because of a programming error. Those old strategy guides recommending Guardian Spirit + Invulnerability rushes... they were so effective because they unknowingly exploited a bug!!
Re:The way Microsoft patched a recent bug raised some eyebrows
by snarfy on Tuesday November 21, 2017 @05:13AM
(#15746938)
I used to do this a lot with shareware using a tool called SoftICE. If you ever saw a message box along the lines of "This feature is only available in the paid version...", it was easy enough to pop the debugger, work backwards to see the conditional that causes the message, change to a nop/edit the value, put the instruction pointer back, then continue on with the paid feature. I miss SoftICE.
Re:The way Microsoft patched a recent bug raised some eyebrows
by microcolonel on Tuesday November 21, 2017 @05:05AM
(#15746899)
> ...because the bug went away in some Wine update shortly thereafter.
So what you're saying is that Wine is more Windows compatible in the case of AoW than Windows itself? :- )
Re:The way Microsoft patched a recent bug raised some eyebrows
by b0rsuk on Tuesday November 21, 2017 @05:54AM
(#15747070)
Wine makes a point to reproduce all unfixed Windows bugs, because notable software was written assuming they exist. I don't envy Wine maintainers!
Re:The way Microsoft patched a recent bug raised some eyebrows
by int_19h on Tuesday November 21, 2017 @03:16PM
(#15751168)
I don't think it was deliberate, to be honest. The bug is really in the game code, but it only manifests when a DirectDraw surface is allocated in just the right way, if I remember the gist of it correctly. Wine likely didn't intentionally fix it - they just changed something about their implementation that accidentally made it go away, and Win10 also changed something that made it repro. I don't actually know if Wine has it again now - it might, I haven't tested that game under it in ages.
https://github.com/int19h/aow-patch
http://steamcommunity.com/app/61500/discussions/0/2154397748...
Originally it was a fix for a bug that would show up when running it under Wine. Now the game is re-released on Steam and GoG, and same thing came up on regular Win10.
The funniest part is, I don't even remember what the patch does - I made it 12 years ago! I remember spending a lot of time reading disassembly, trying to figure out what's going on, and eventually figuring just enough to plug the immediate hole. Then I posted the binary diff on a forum, and subsequently forgot all about it, because the bug went away in some Wine update shortly thereafter.
http://aow.heavengames.com/cgi-bin/forums/display.cgi?action...
When I dug that diff out, it made zero sense to me. So now not only there's no source for the game, but I've "lost the source" for the patch, as well - I'd have to reverse engineer it all again to figure out what it actually does. ~