News for hackers. Stuff that matters.
Re:Ask HN: What are the best tools for code reviews? by matttproud on Friday November 17, 2017 @11:21AM (#15723312)
Re:Ask HN: What are the best tools for code reviews? by chrisjshull on Friday November 17, 2017 @11:57AM (#15723675)
I’d warn against Gerrit. From the best my team has been able to figure out, Gerrit encourages a development flow that breaks the golden rule of rebase and treats all pushes as force pushes. The result is that in a collaborative environment your changes are occasionally reset by someone else pushing changes.

(To my eye Gerrit seems like it was written by people who wanted git to work like svn.)

Re:Ask HN: What are the best tools for code reviews? by khazhou on Friday November 17, 2017 @12:48PM (#15724164)
They've set it up wrong. I use Gerrit in a large team and have never seen that problem. Force push is explicitly disabled in our config.
Re:Ask HN: What are the best tools for code reviews? by zwily on Friday November 17, 2017 @12:29PM (#15723989)
You can configure Gerrit to cherry-pick, and I believe the default is to do a merge.
Re:Ask HN: What are the best tools for code reviews? by usr1106 on Saturday November 18, 2017 @04:25AM (#15728378)
We tried to introduce it at work 2-3 years ago. We never got over a pilot installation. It seems rather challenging to install/configure into an existing automatic build system, because gerrit wants to be its own git server(?), but the implementation/hooks are not compatible with "normal" git. Didn't work with that part, so don't remember the details. The UI did not feel very intuitive, might be quite a learning curve.
Re:Ask HN: What are the best tools for code reviews? by arjun27 on Friday November 17, 2017 @12:12PM (#15723834)
What do you like about it?