News for hackers. Stuff that matters.
Re:Simple React Patterns by loevborg on Friday November 10, 2017 @04:26AM (#15668839)
When you say "cancellable promises", that means that you cannot use native JS promises, correct?
Re:Simple React Patterns by Guillaume86 on Friday November 10, 2017 @06:05AM (#15669148)
You can, you just need to wrap it when used inside a react component.
Re:Simple React Patterns by drdaeman on Friday November 10, 2017 @07:37AM (#15669443)
How?

I've thought it's just technically impossible (no API to do so) to cancel a `fetch` request in progress.

Re:Simple React Patterns by Guillaume86 on Friday November 10, 2017 @08:53AM (#15669841)
We're talking about several different things:

Native promises do not have a "real" cancellation API (no 3rd path besides resolved and rejected) but you can mimic the functionality by rejecting with a dedicated error type, or use another promise as a cancellation token for example.

fetch(), which uses promises as return type, do not support aborting requests, as discussed [here](https://github.com/whatwg/fetch/issues/447) but the [old XMLHttpRequest does](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequ...).

Aborting is specific to HTTP requests, it's stopping the connection to the remote server (so technically impossible to implement with the current APIs as you said). Cancelling a promise is just stopping all onResolved continuations to be called, so it can be implemented in several different ways as I explained above.

The end result if you use a classic cancellation wrapper on a fetch() promise is that the onReject continuations will be called immediately with a specific reason. The HTTP request will continue to the end (no abort), but the response will be ignored.

In the case of the react library I mentioned, both the onResolved and onReject continuations will be ignored if cancelled, it's the subtlety that allows the component to be garbage collected (and probably why the author decided to call that "thrashable" as opposed to "cancellable" to mark the difference).

Re:Simple React Patterns by always_good on Friday November 10, 2017 @11:05AM (#15670771)
For example, you can wrap a promise such that when it finally resolves, it checks an isCancelled flag and rejects instead so that your .then callbacks aren't run.

It's not about cancelling any potential inflight action within the promise itself.

In this case, you don't want the callback to run after the react component unmounts, nor do you want to hold a reference to the component:

    promise
        .then(value => this.setState({ value }))
Re:Simple React Patterns by myhf on Friday November 10, 2017 @08:17AM (#15669636)
You don't have to cancel the fetch request, you just have to cancel its callback.