Write tests. Not too many. Mostly integration

Re:Write tests. Not too many. Mostly integration by positivecomment on Friday October 27, 2017 @06:02AM (#15567012)

> Shoot the reviewer

Duly noted! Although I'll try talking to her first, I'm sure there's more behind the decision :)

One of the methods that was inside takes a request, extracts the body and returns the parsed graph from the body. It's used by many controllers from many projects. I don't know where to put such a thing, hence the request extension.

[ Parent | on HN ]

Re:Write tests. Not too many. Mostly integration by cjsuk on Friday October 27, 2017 @06:06AM (#15567026)

Always ask for the reason before slating it :)

Usually that's a single responsibility class:

   interface IGraphParser {
       Graph Parse(Request request);
   }

Inject that into the caller via the container then you can mock the thing that calls it and just return a static Graph object, which you can't do with a simple extension method (which is why it sucks).

[ Parent | on HN ]