(ns add-nums
(:use compojure.core [hiccup core page-helpers] ring.adapter.jetty))
(defroutes handler
(GET "/add-nums" [a b]
(let [a (Integer/parseInt a)
b (Integer/parseInt b)]
(html
[:html
[:head [:title "Add two numbers"]]
[:body
(if (and a b) [:p (+ a b)])
(form-to [:get "/add-nums"]
(text-field :a)
(text-field :b)
(submit-button))]])))
(run-jetty handler {:port 8080})
Mark's tutorial code is a little more complete than your example, and doesn't aim for brevity. It also doesn't use any of the form functions from Hiccup (admittedly, they're not as well documented as they could be).Thank you! It's good to know that verbosity was for the sake pedagogy and completeness, and not necessity.
* you've omitted code to control the output content-type and the associated response headers (xhtml vs html)
* you've removed text, formatting from the form page
* you've discarded the results page altogether
* you aren't properly distinguishing between GET and POST
Do the same to the clojure code and it'll be about the same length as well.
you've omitted code to control the output content-type and the associated response headers (xhtml vs html)
Add this single line to your WITH-HTML macro.
(setf (html-mode) :xml) ; for XML or :sgml for HTML.
http://weitz.de/cl-who/#html-modeyou've removed text, formatting from the form page
Add one line for a CSS file inclusion and style it to your heart's content. In real web apps I use html-template to template the code, and do not sloppily generate html like I did with the example; but I had to do what the clojure code did, in the same manner.
you've discarded the results page altogether
I am printing the results on the same page. Yeah, that's a better usability.
you aren't properly distinguishing between GET and POST
Says who? the DEFINE-EASY-HANDLER takes arguments, which correspond to the submitted form elements, via GET or POST. In fact, that macro also does some type conversion for you as well; since you declared your parameters to be integers they will be converted to integers when you get them, and not remain strings. This stuff is built into the web server.
http://weitz.de/hunchentoot/#define-easy-handler
If you're gonna implement a full REST then you have no business generating your display html from within your container.
What else do you think I omitted?
First sophistry and now this .. sophistication. I think I am out of my intellectual depth here, and you will have to excuse me for bidding you an early adieu!
[Edit:
I see you have only registered a day ago, welcome aboard! But can you please be a little gentle? (specially in sentences containing a 2nd person pronoun.)
I have been screaming for ages telling Clojurists to rip CL APIs and implement them in clojure. They're more tasteful and cultured than that entrerprisey crap that java is smearing all over this nice Lisp dialect.
The majority of open source clojure code that I have seen looks like Java FFI stubs; you need to tuck those loose ends in and tidy them up with macros. But this probably wont happen until Clojure is ported to another runtime/platform; portability is a surefire way to distill the essence of a language from its implementation detail.
Care to help? If you feel this strongly about it, surely you can contribute to the community.
My advice is just that, advice, and it's given in the hope that with our mutual situations improved, maybe we can meet for coffee somewhere down the road and kick it back.