News for hackers. Stuff that matters.
Re:Moving away from GitFlow by alkonaut on Monday October 02, 2017 @08:29AM (#15383287)
> Skipping code reviews for faster pushes to "trunk" does not sound like a stable solution.

I think a important context here is that this is engine code (a.k.a. library code).

This isn't a web service or web site where what you ship is hitting end users. The end users of this code produce new products, and the potential issues are a) that the users of the engine (i.e. game studios, internal users of Stingray etc) are being held up in their work, or b) that bugs sneak through to their users (the gamers/end users).

In this context, the idea of a quicker turnaround in exchange for some bugs leaking through is much easier to defend. The studio might want the buggy code faster rather than the fixed code later. This is probably not the case for a system deployed directly to end users.

> Why not just encourage faster reviews and smaller diffs..

That was the motivation of switching to trunk based (i.e. removinbg the incentive and slowness of larger PR's). You can't "encourage" smaller diffs other than having the process inherently do that. It's not "encouraging" to send an email to the team telling them to make smaller diffs.

There are no comments on this comment yet.