Re:Abseil: C++ Common Libraries
by shahms on Tuesday September 26, 2017 @05:39PM
(#15342751)
Why would you wish maintenance of either of those things on your coworkers?
[ Parent
| on HN ]
As grandparent illustrates, this matters to users. So it matters to me too.
As one of your users, I'd really like to stop maintaining our own BUILD files for proto :-)
I don't follow what you are saying. Protobuf has a BUILD file: https://github.com/google/protobuf/blob/master/BUILD Do you mean something else?
A GitHub issue might be a better place for this discussion.
Re:Abseil: C++ Common Libraries
by packetslave on Tuesday September 26, 2017 @07:37PM
(#15343622)
As another of your users, I really wish the proto_library BUILD rules were open-source :-)
If you feel like you are missing implicit dependencies on building haskell in your project, you could always just add it.
I wasn't aware Protocol Buffers had any relation to Haskell; would you mind explaining what you're referring to here?
Re:Abseil: C++ Common Libraries
by 7197ghr918hf on Tuesday September 26, 2017 @10:31PM
(#15344437)
Googler-on-googler trolling. The internal version of the build rule they're discussing has some busted dependencies. Because of historical cruft, it brings in a lot of unrelated crap. For example, building a C++ binary might build bring in Haskell dependencies because of a protocol buffer. This is being fixed, but it's been a thorn in our sides for years.
To expand a bit, the proto_library rules were "famously" broken in that it never knew which outputs were actually used (Or so i believe that was the cause, it's been a while)
Thus, it assumed the output was needed for any language specified in the proto library rule. So if your proto library rule offered a haskell version, anything using that proto library rule would do what was necessary (usually, building haskell stuff) to make that output.
The more people offered more languages in their rules, the worse it got.
I believe this was eventually fixed (i stopped coding in the main repo years ago, these days, i only hack on open source projects).
I expect one reason the rule was not open sourced was to not expose this cruft to the rest of the world :)