News for hackers. Stuff that matters.

A comment on React 16. Parent comment

Re:React 16 by captnasia on Tuesday September 26, 2017 @01:13PM (#15340617)
If you go to the Portals documentation ( https://facebook.github.io/react/docs/portals.html ) you can find some examples throughout.
[ Parent | on HN ]
Re:React 16 by teraflop on Tuesday September 26, 2017 @01:54PM (#15341013)
Both of the CodePen example links on that page are insidiously broken. The demos appear to work, but they don't actually demonstrate the claimed portal functionality at all:

    // These two containers are siblings in the DOM
    const appContainer = document.getElementById('app-container');
    const modalContainer = document.getElementById('app-container');
Note that both variables refer to the same element.
[ Parent | on HN ]
Re:React 16 by danabramov on Tuesday September 26, 2017 @02:02PM (#15341104)
Sorry, there was so much to do in the release that some issues crept into the new docs. We'll fix them soon. :-)
[ Parent | on HN ]
Re:React 16 by acdlite on Tuesday September 26, 2017 @02:23PM (#15341298)
Fixed now! Thanks for the bug report!
[ Parent | on HN ]
Re:React 16 by teraflop on Tuesday September 26, 2017 @06:37PM (#15343215)
No problem! And on re-reading my comment, I probably shouldn't have used the word "insidiously", it came off a lot more negative than I intended. Thanks for the quick fix.
[ Parent | on HN ]