News for hackers. Stuff that matters.
Re:Launch HN: PullRequest (YC S17) – On-Demand Code Review by fergie on Thursday August 17, 2017 @11:48AM (#15037823)
What are the benefits of reviewers over automated testing?

My workflow (which I believe is pretty standard) is:

* Write code

* Verify that tests pass locally (including stylistic tests, linting)

* Submit pull request

* Pull request triggers build and tests on Travis

* If all tests pass on Travis, code is stylistically and functionally correct

* Merge pull request

How can human reviewers improve this workflow?

Re:Launch HN: PullRequest (YC S17) – On-Demand Code Review by sz4kerto on Thursday August 17, 2017 @11:51AM (#15037861)
> If all tests pass on Travis, code is stylistically and functionally correct

Passing tests don't prove that

- tests are covering all functional criteria required

- the code doesn't add 'technical debt', i.e. structural problems that will have to be refactored/worked around in the future.

Re:Launch HN: PullRequest (YC S17) – On-Demand Code Review by paradite on Thursday August 17, 2017 @12:32PM (#15038241)
- check for best practices

- check for whether external or downstream services would be affected (in the absence of complete e2e testing)

- check for coding conventions and standards that are not enforceable by linters, such as naming conventions, code structuring, positive/negative testing, effective usage of helper methods

- check for typos

Re:Launch HN: PullRequest (YC S17) – On-Demand Code Review by yessql on Thursday August 17, 2017 @12:01PM (#15037953)
I can write sort algorithms that are nlog(n) or n^2. Both pass functional tests.

I can write code that reinvents the wheel, instead of using the solid library I've never heard of.

I can do things in non-idiomatic ways that testing and linting will never catch.

Re:Launch HN: PullRequest (YC S17) – On-Demand Code Review by maaaats on Thursday August 17, 2017 @11:55AM (#15037895)
Those things have nothing to do with a PR, other than maybe a PR being a good way to say "this is done, let's automatically verify it".

A PR is about showing the rest of the team the changes so more than one person knows how stuff work and what's going on in the code base. And for the rest of the team to give feedback on stuff like how the feature was architected, not to nitpick on indenting.

Re:Launch HN: PullRequest (YC S17) – On-Demand Code Review by icebraining on Thursday August 17, 2017 @01:34PM (#15038904)
A PR is about showing the rest of the team the changes so more than one person knows how stuff work and what's going on in the code base.

But that's not really applicable here, right?