And, yes, war is NOT good for the economy or anything else, other than repelling invaders. When all your shit's blown up, you ain't got shit.
I figure that without the wars of the 20th century, we'd all have twice as much wealth, if not more.
So on the one hand, you are right, war is a destroyer of wealth. But on the other hand, the US benefitted enormously from it. The net effect was to concentrate wealth that would have existed in territories of its rivals to it.
We are told the Marshall Plan worked wonders. But interestingly, two countries that were both enemies ended up with very successful economies. And both were bombed pretty hard at the end of the war.
Which makes me think that a nation's culture and the freedom its citizens have to take risks and benefit from doing so are more important than handouts. But you could probably guess I was already pretty biased in that direction.
War productions does not make prosperous societies simply because the allocation of resource is redirected to military purpose, not to civilian needs.