In the article, "They" in your first quote refers to evening people, so I'm not entirely sure I understand what you're trying to say here.
But I am pretty sure the "who" refers to the morning people. So morning people are said to be more optimistic, and they give themselves higher ratings in a questionnaire. It is therefore not clear if they give themselves higher ratings because they are really better, or because they are just more optimistic about their performance.
Re:Why morning people rule the world
by JohnnyBrown on Monday July 05, 2010 @04:06PM
(#1488979)
What time of day were those questions asked?
...
"It was the morning people who were more likely to agree with statements such as “I feel in charge of making things happen” and “I spend time identifying long-range goals for myself.”"
...
I'd say back to the drawing board it is...