News for hackers. Stuff that matters.

A comment on How we made compiler warnings fatal in Firefox.

Re:How we made compiler warnings fatal in Firefox by crispweed on Wednesday July 05, 2017 @06:20AM (#14701212)
One big reason to make compiler warnings fatal (not mentioned here, as far as I can see) is the fact that otherwise, unless you do a full rebuild, you won't see warnings for any source files that don't need to be rebuilt.
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by xroche on Wednesday July 05, 2017 @10:18AM (#14702563)
The other reason is that people are lazy, and soon, you will have thousands of warnings, and as a logical result, people will simply ignore them all.
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by noselasd on Wednesday July 05, 2017 @08:16AM (#14701756)
We use the Warnings plugin and set Jenkins to always do a full build, so we can have a good overview of potential warnings on the various platforms a project is built on.

Not surprisingly, 0 warnings on your dev machine doesn't mean you also have 0 warnings on a production build for another architecture..

[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by jhasse on Wednesday July 05, 2017 @07:56AM (#14701652)
That's always something where I think current build systems are failing.
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by softawre on Wednesday July 05, 2017 @11:12AM (#14703005)
But if you didn't change a file, do you really want to see warnings for it? Wouldn't you rather just see warnings for stuff you changed and see all of the warnings when a full build is done in CI?
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by crispweed on Wednesday July 05, 2017 @12:25PM (#14703770)
I guess the ideal would be the possibility to see both.
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by connorcpu on Wednesday July 05, 2017 @11:59AM (#14703509)
Perhaps not build systems, but I think editors that help you keep track of warnings should probably have a list of them per-file and only clear that list when the file actually gets rebuilt
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by jhasse on Wednesday July 05, 2017 @01:26PM (#14704380)
I don't know, I'd rather have that functionality in the build system. The editor should just parse the build system's output and keep the stuff it does to a minimum.
[ Parent | on HN ]
Re:How we made compiler warnings fatal in Firefox by jcoffland on Wednesday July 05, 2017 @02:05PM (#14704773)
Why not just fix the warnings and be done with it? Seems like far less work to me.
[ Parent | on HN ]