Depends on the market. They're not so hot in the Chicago suburbs, where buyers have the option of newer construction "modern" homes in addition to pre-WWII vintage homes: https://chicago.curbed.com/2016/9/13/12902744/chicago-mcmans...

There are some metro areas where your only choices are basically McMansions or obsolete post-war housing. Given those limited options, it's no surprise why people prefer them.