Re:How not to build a ship: the USS Ford
by scottLobster on Friday June 09, 2017 @04:26PM
(#14524248)
Yeah I'd say the issue there is that traditional defense contractors are highly silo-ed, quality can vary drastically from program to program. I've worked on programs that I'd pit against Google and programs where the culture was a bunch of math majors who learned to code in the 70s and haven't updated since the 90s. Just last year I had to review a 500 line FUNCTION in NEW CODE.
Thankfully I'm no longer attached to that program, had to continuously bite my tongue and pick my battles in code reviews to avoid getting a reputation. Even nicely telling people 15-20 years my senior "go spend two days refactoring this crap" was a non-starter. To be fair the code did work, I doubt a user would ever notice. But I felt bad signing off on the review all the same.
I sdhould point out that not all the old-timers are a problem. I'm currently working with some 20-year guys who are VERY up to date and open to new ideas; and the company is trying to modernize from the top-down, but some programs have taken to it better than others and some have outright resisted. Given that these programs are only staffed after a bid is won, I'm not sure what kind of vetting process could catch these kinds of inefficiencies.
Thankfully I'm no longer attached to that program, had to continuously bite my tongue and pick my battles in code reviews to avoid getting a reputation. Even nicely telling people 15-20 years my senior "go spend two days refactoring this crap" was a non-starter. To be fair the code did work, I doubt a user would ever notice. But I felt bad signing off on the review all the same.
I sdhould point out that not all the old-timers are a problem. I'm currently working with some 20-year guys who are VERY up to date and open to new ideas; and the company is trying to modernize from the top-down, but some programs have taken to it better than others and some have outright resisted. Given that these programs are only staffed after a bid is won, I'm not sure what kind of vetting process could catch these kinds of inefficiencies.