News for hackers. Stuff that matters.

A comment on Node v8.0.0 Released. Parent comment

Re:Node v8.0.0 Released by kasbah on Tuesday May 30, 2017 @06:22PM (#14449029)
>request = util.promisify('superagent')

I don't think that's required. Superagent already returns promises.

[ Parent | on HN ]
Re:Node v8.0.0 Released by nailer on Wednesday May 31, 2017 @01:20AM (#14450576)
Ah you're right!

https://visionmedia.github.io/superagent/#promise-and-genera...

Alas too late to edit comment.

[ Parent | on HN ]
Re:Node v8.0.0 Released by candu on Wednesday May 31, 2017 @10:12AM (#14452650)
Sure, but having `util.promisify` in core modules means you no longer need an external dependency here.
[ Parent | on HN ]
Re:Node v8.0.0 Released by kasbah on Wednesday May 31, 2017 @02:04PM (#14454612)
Hm? It's not an external dependency. Superagent returns a promise.
[ Parent | on HN ]