News for hackers. Stuff that matters.
Re:Travis CI Security Advisory: Secured Environment Variables by nothrabannosir on Monday May 08, 2017 @06:25PM (#14296207)
Only if you merge it in. The point is the secure environment variables are not available at all in the fork build. The bash oneliner they show is to help you run scripts which won't crash if they don't have those env vars available, not to "hide them" by running a test script which doesn't use them.
Re:Travis CI Security Advisory: Secured Environment Variables by tehlike on Monday May 08, 2017 @11:52PM (#14297616)
I know many instances where code reviews didnt catch log statement in huge binaries.
Re:Travis CI Security Advisory: Secured Environment Variables by nothrabannosir on Tuesday May 09, 2017 @03:36AM (#14298341)
Right, but now you're in the "review of a PR didn't catch malicious code" boat. At which point, you've got bigger problems than leaking env vars in your CI.

Not to dismiss it---it's just a different point.