Re:TLS verification vulnerability in LibreSSL 2.5.1-2.5.3
by gpvos on Friday May 05, 2017 @09:24AM
(#14273222)
I think erdeszt is just referring to the lack of curly braces around the statements governed by the if statements. This can be done around any single-line statement block, and is generally safer in the face of merges from version control.
Re:TLS verification vulnerability in LibreSSL 2.5.1-2.5.3
by erdeszt on Friday May 05, 2017 @09:21AM
(#14273210)
I was referring to the lack of curly braces around the body of the then clause.
This code has nothing to do with resource management and gotos per se so I don't see where your frustration and attack comes from.
The specific code isn't "goto fail" anyway, it is more akin to a finally block.