News for hackers. Stuff that matters.
Re:Fewer mallocs in curl by userbinator on Sunday April 23, 2017 @12:18PM (#14178765)
Curl now uses the idiom where the linked list data (prev/next pointers) are inlined in the same struct that also holds the payload.

I wonder why this wasn't the original design; I've seen the "two-allocate" method a few times in other code and it's always seemed rather silly to allocate that separate little structure just to point to the things you're linking together anyway, so I'm curious how that way of doing it became somewhat commonplace.

Re:Fewer mallocs in curl by masklinn on Sunday April 23, 2017 @12:29PM (#14178825)
Mayhaps because the structure was originally stack-allocated, or because the developer was unfamiliar or uncomfortable with intrusive datastructures. Or because the structure is used outside of linked list contexts and the memory overhead of the intrusion was considered not compensated for?
Re:Fewer mallocs in curl by tom_mellior on Sunday April 23, 2017 @01:04PM (#14179012)
> Or because the structure is used outside of linked list contexts

That use case is possible with the particular implementation that is now used by curl:

    struct fileinfo {
      struct curl_fileinfo info;
      struct curl_llist_element list;
    };
You can use the payload (struct curl_fileinfo) outside of a list without incurring any overhead.

I think one of your other points is more likely, or simply "it was fast enough and we went for more interesting features than for such optimizations".

Re:Fewer mallocs in curl by wbl on Sunday April 23, 2017 @02:37PM (#14179621)
One of the Plan 9 C enhancements makes this even easier by permitting the fields of these structs to be accessed directly.
Re:Fewer mallocs in curl by generic_user on Monday April 24, 2017 @03:39AM (#14182539)
you can do this now in ISO C11 with the inclusion of anaonomous structures and unions.

    struct A { 
        int x, y; 
    };

    struct B {
        union {
            struct A 2d;
            struct { int x, y; };
        }
        int z;
    };

    ...

    struct B foo;
    foo.x = foo.2d.y = foo.z = 0;
you can access x and y as members of B or A.
Re:Fewer mallocs in curl by tomlu on Sunday April 23, 2017 @05:30PM (#14180565)
Well there are situations where intrusive list pointers don't work well. If you don't control the class, then you simply can't put pointers in it. If most objects aren't ever in a list (eg. a million objects but only ten in a list at any given time), then you're wasting space. If you want to put objects in several different lists, then you have to know up front how many lists and their names, and this can become unmanageable.
Re:Fewer mallocs in curl by daemin on Monday April 24, 2017 @06:55AM (#14183267)
You can always allocate memory big enough for a the payload plus the link structure without the links actually being inside of the payload. Just make the first part of memory contain the links and immediately afterward you have the payload.
Re:Fewer mallocs in curl by kzrdude on Sunday April 23, 2017 @03:02PM (#14179794)
It's the object oriented approach isn't it? So it will be natural to some (because it was taught to them that way).