Re:Interviewing programmers: coding test example explained
by loup-vaillant on Monday June 07, 2010 @03:02AM
(#1410049)
I considered the `c=='\0'` case bogus anyway, so I was OK with a partial function. (I wouldn't have been for production code, though.)
[ Parent
| on HN ]
Re:Interviewing programmers: coding test example explained
by RiderOfGiraffes on Monday June 07, 2010 @03:18AM
(#1410066)
Are you saying that you actually considered that case, and then wrote code that didn't deal with it?
Re:Interviewing programmers: coding test example explained
by loup-vaillant on Tuesday June 08, 2010 @09:23AM
(#1413806)
Yes I did, and then yes I did.
I didn't fully investigated that case, but I suspected there could be a problem with `c=='\0'`. I suspected that the `while (s[from] == c) from ++;` line could shoot past the termination '\0' and trigger a buffer overflow.
But I didn't fully investigate, on the grounds that no sane programmer would want to remove a character that's never in a C string. In other words, I considered it was not part of the specification.
In production code, I would have either thrown an exception, or returned early. And I would have asked around to know which I would chose.
Could my attitude have influenced my chances, if I had applied?