Re:Machine Learning from scratch: Bare bones implementations...
by metaobject on Saturday February 25, 2017 @10:38PM
(#13735525)
In your RandomForest implementation, on the line in fit() where you're building the training subsets to give to each tree, it appears that your bagging approach doesn't use 'sampling with replacement' strategy.
It would appear that the replace=False prevents the 'sampling with replacement' behavior usually implemented by bagging algorithms. Should the replace=False be changed to replace=True?
[ Parent
| on HN ]
Re:Machine Learning from scratch: Bare bones implementations...
by eriklindernoren on Sunday February 26, 2017 @07:09AM
(#13736847)
Thank you for your feedback! I have read up on the feature bagging part of the algorithm and I believe that you are correct. This is fixed in the latest commit.