So applying a single test to a huge general population makes little sense. But applying that to a population that already carries some traits is highly relevant.
It's not magic, it's applied statistics.
If your probabilities are on the order of 'nonexistent' and your test has a false positive rate on the order of a few 10'ths of a % then you are wasting your time no matter what the method you use to analyze your data.
With no tests, the quiet unassuming terrorist would still walk by.
At least with a test with some efficacy at catching legitimate terrorists even with false positives would be better no?
(Going only by the metric of catching terrorists.)
The test is useful, just not useful enough to transform a random population into a list of suspects. It's useful for what the FBI says it's getting used for - determining how to allocate resources among a limited population that's already under suspicion. Eg, be more likely to assign an active agent if the case involves people with access to weapons.
If you're concerned about a few million people to spot 10 (a high estimate) per year then you will need better tools than dragnet surveillance and questionnaires like these. Did you really expect to answer any of these questions about a would-be terrorist in such a way that it would help an investigation?
Check the questions, it's positively skewed towards one particular kind of terrorist (young Islamic males even though it does not state that outright it might as well be written there). And then you get your nice, upstanding Christian white-guy who murders 6 people in cold blood and would have murdered a whole lot more if he had the chance.
These questions are meaningless without accurate priors and accurate priors require incidence rates that are distinguishable from noise.
Bad tests are worse than no tests.