Our long term plan to make GitLab as fast as possible with Vue and Webpack

Re:Our long term plan to make GitLab as fast as possible wit... by zeven7 on Tuesday February 07, 2017 @11:56AM (#13590646)

    > Regarding class vs. className: class is a reserved word
    > in JS. It's not really a perf thing, it's the fact that
    > JSX was intended as a very simple transform. If JSX used
    > class instead of className, the transpiler would need to
    > be contextual since "class" would sometimes mean "css
    > class" and sometimes "JavaScript class".

I don't think React should have used `class` instead of `className`, but this isn't the reason.

    <foo className="bar" />

compiles to

    React.createElement("foo", { className: "bar" });

It could have just as easily have been that

    <foo class="bar" />

compiles to

    React.createElement("foo", { 'class': "bar" });

as far as JSX is concerned (or even without the quotes in an ES5 world).

[ Parent | on HN ]

Re:Our long term plan to make GitLab as fast as possible wit... by nkohari on Tuesday February 07, 2017 @12:18PM (#13590844)

The output isn't the problem; it's that "class" is also a keyword in the JSX input. I admit, though, I'm not intimately familiar with the JSX transpiler and am just guessing as to their motives.

[ Parent | on HN ]