Our long term plan to make GitLab as fast as possible with Vue and Webpack

Re:Our long term plan to make GitLab as fast as possible wit... by Bahamut on Tuesday February 07, 2017 @10:36AM (#13589971)

className was named that to avoid conflict with the JS class syntax originally I believe, since JSX is inline - they probably could put in the work to change it at this point, but it seems like a minimally beneficial change but massively disruptive at this point.

[ Parent | on HN ]

Re:Our long term plan to make GitLab as fast as possible wit... by jmtulloss on Tuesday February 07, 2017 @10:58AM (#13590173)

It was named that to match the DOM api[0], which React does whenever possible. The DOM api is probably named for the reason you state.

[0]: https://developer.mozilla.org/en-US/docs/Web/API/Element/cla...

[ Parent | on HN ]

Re:Our long term plan to make GitLab as fast as possible wit... by rmetzler on Tuesday February 07, 2017 @01:17PM (#13591327)

And the reason why the DOM API uses className is: class is a reserved keyword in JavaScript for a long time.

[ Parent | on HN ]

Re:Our long term plan to make GitLab as fast as possible wit... by lhorie on Tuesday February 07, 2017 @03:42PM (#13592573)

There's also stuff like onClick, readOnly, xlinkHref... I would guess that a healthy number of React-related google searches are related to these gotchas

[ Parent | on HN ]