Go Proposal: Accept GitHub PRs

Re:Go Proposal: Accept GitHub PRs by Manishearth on Thursday January 05, 2017 @08:29PM (#13333180)

With Servo we use https://reviewable.io/ on github.

We don't enforce its use. If a newcomer makes a pull request, we'll just use the GH review interface. In general simple PRs go through the GH review interface, regardless of who they're from. We break out Reviewable when a PR actually needs it (this is usually the choice of the reviewer).

This means that Servo continues to have a lower bar to contribution, without hampering maintainers on PRs that need more than GHs set of review features.

This has worked out well for us.

[ Parent | on HN ]

Re:Go Proposal: Accept GitHub PRs by StevePerkins on Thursday January 05, 2017 @09:10PM (#13333349)

I've contributed to another Google project (http://vitess.io) that used the the same process. So while Go is a completely different team, it's not exactly unknown within Google. Reviewable is a dramatic improvement over the stock Github tooling.

[ Parent | on HN ]