News for hackers. Stuff that matters.
Re:Go Proposal: Accept GitHub PRs by eridius on Thursday January 05, 2017 @05:57PM (#13332257)
Oh yeah, collapsing whitespace-only changes is excellent. But even better is how it can detect and collapse changes introduced by rebasing the PR.
Re:Go Proposal: Accept GitHub PRs by petetnt on Thursday January 05, 2017 @07:53PM (#13332965)
You can hide whitespace-only changes in GitHub by appending ?w=1 to the end of the url too.
Re:Go Proposal: Accept GitHub PRs by eridius on Thursday January 05, 2017 @08:13PM (#13333094)
But that makes the whitespace changes literally invisible. Reviewable strikes a good balance, where it will show you whitespace changes that appear in diff hunk contexts, and also explicitly call out when it's skipping a chunk of whitespace-only changes, and you can click on that callout to ask it to show you those whitespace changes anyway.
Re:Go Proposal: Accept GitHub PRs by helper on Friday January 06, 2017 @09:58AM (#13336672)
Reviewable doesn't hide whitespace changes, it shows just enough so you can tell that whitespace changed without getting in the way of reading the rest of the diff.