News for hackers. Stuff that matters.
Re:Go Proposal: Accept GitHub PRs by eloff on Thursday January 05, 2017 @04:37PM (#13331647)
IIRC one of the problems was github notifies you as soon as a comment is posted, potentially wasting your time if you go look before the comments are finalized. For example you may see a comment asking how something works, and waste time replying only to see the comment was since deleted because the reviewer figured it out.

I don't think the issues were really that serious, but the Go team likely saw no reason to change away from the tool they were comfortable with for a slightly worse tool that they would have to adapt to.

Re:Go Proposal: Accept GitHub PRs by rickcnagy on Thursday January 05, 2017 @04:40PM (#13331677)
The new GitHub changes allow you to group a set of comments into a "review" that then notifies the recipient all at once, along with letting you mark the PR as "approved" or "needs changes".
Re:Go Proposal: Accept GitHub PRs by wyldfire on Thursday January 05, 2017 @05:02PM (#13331840)
Interesting. I found Gerritt's behavior (the flipside) to be a little frustrating. I just have one comment, right here: <x> -- why do I need to publish it and give it a meta-comment?
Re:Go Proposal: Accept GitHub PRs by steveklabnik on Thursday January 05, 2017 @07:22PM (#13332789)
GitHub's new flow gives you both choices: a "just this one comment" button and a "start a new review" button.