Re:Rust is mostly safety
by steveklabnik on Thursday December 29, 2016 @04:06PM
(#13280131)
Integer overflow is defined to panic in debug builds, and either do that or two's compliment overflow in release builds. The current implementation overflows. However, zero is not false.
Re:Rust is mostly safety
by smitherfield on Thursday December 29, 2016 @04:16PM
(#13280200)
I assume that treating 0 as false was intentional in this case (it probably was written in PDP-11 ASM) and a direct translation of the Therac code therefore would be
if counter > 0 {
deploy_radiation_shield();
}
Re:Rust is mostly safety
by steveklabnik on Thursday December 29, 2016 @04:22PM
(#13280234)
Yeah, you'd certainly have to see the actual code to be sure, I bet you're right.
Caused by unsigned 8-bit integer overflow combined with (presumably) treating 0 as falsy. May or may not have been solved by using Rust (but probably wouldn't have because it sounds like a logic error in "clever" code).
> Errors in the software of a MIM-104 Patriot…
Caused by loss of precision in floating-point calculations. Would not have been solved by using Rust.
The other two were more likely human or mechanical than (unspecified) software errors.